فهرست منبع

Compare string length instead of empty string

Zed 7 سال پیش
والد
کامیت
89b6cfdf98
3فایلهای تغییر یافته به همراه6 افزوده شده و 6 حذف شده
  1. 1 1
      src/api.nim
  2. 1 1
      src/formatters.nim
  3. 4 4
      src/nitter.nim

+ 1 - 1
src/api.nim

@@ -74,7 +74,7 @@ proc getTimeline*(username: string; after=""): Future[Tweets] {.async.} =
   })
 
   var url = timelineUrl % username
-  if after != "":
+  if after.len > 0:
     url &= "&max_position=" & after
 
   let html = await client.fetchHtml(base / url, jsonKey="items_html")

+ 1 - 1
src/formatters.nim

@@ -81,7 +81,7 @@ proc linkUser*(profile: Profile; h: string; username=true; class=""): string =
     if username: "@" & profile.username
     else: formatName(profile)
 
-  if h == "":
+  if h.len == 0:
     return htmlgen.a(text, href = &"/{profile.username}", class=class)
 
   let element = &"<{h} class=\"{class}\">{text}</{h}>"

+ 4 - 4
src/nitter.nim

@@ -11,10 +11,10 @@ proc showTimeline(name: string; num=""): Future[string] {.async.} =
     tweetsFut = getTimeline(username, after=num)
 
   let profile = await profileFut
-  if profile.username == "":
+  if profile.username.len == 0:
     return ""
 
-  return renderMain(renderProfile(profile, await tweetsFut, num == ""))
+  return renderMain(renderProfile(profile, await tweetsFut, num.len == 0))
 
 routes:
   get "/":
@@ -29,7 +29,7 @@ routes:
   get "/@name/?":
     cond '.' notin @"name"
     let timeline = await showTimeline(@"name", @"after")
-    if timeline == "":
+    if timeline.len == 0:
       resp Http404, showError("User \"" & @"name" & "\" not found")
 
     resp timeline
@@ -37,7 +37,7 @@ routes:
   get "/@name/status/@id":
     cond '.' notin @"name"
     let conversation = await getTweet(@"id")
-    if conversation.tweet.id == "":
+    if conversation.tweet.id.len == 0:
       resp Http404, showError("Tweet not found")
 
     resp renderMain(renderConversation(conversation))